bitcoin/bips
1
0 Fork 0
mirror of https://github.com/bitcoin/bips.git synced 2026-10-19 19:29:18 +00:00
Code Issues Releases Wiki Activity
3,392 Commits 1 Branch 0 Tags
a0b433471dfa4adfb39844274bf52159e4574cf6
Commit Graph
106 Commits
Author SHA1 Message Date
Gregory Sanders 7e0c47e1f6 uiht 2023-01-17 14:14:54 -05:00
ishaanam 555c1d8c89 BIP 174: fix incorrect reference to BIP 173 2022-08-15 12:38:08 -04:00
Andrew Chow 7cd8ecd111 psbt: Unify formatting of key-value data to specify data type and name 2022-07-13 20:20:39 -04:00
Luke Dashjr 6452b8b7b5 Merge pull request #1290 from allenpiscitello/patch-1 
Fixing incorrect allowing of unsigned transaction
 2022-05-05 16:27:23 +00:00
Brandon Black 1b67c8835f Correct pubkey type for TAP_INTERNAL_KEY 2022-04-04 07:44:44 -07:00
Brandon Black ad6e587232 Fix data type for TAP_MERKLE_ROOT 2022-04-04 07:37:41 -07:00
Brandon Black c876d7e20e Remove repeated clause 2022-04-04 07:37:28 -07:00
allenpiscitello 33f8f62906 Fixing incorrect allowing of unsigned transaction 
V2 does not allow Global Key Type of 0 (Unsigned Transaction), but not listed as excluded in the spec.
 2022-03-24 13:19:16 -05:00
Luke Dashjr 7db0e1a554 Merge pull request #1270 from JeremyRubin/patch-2 
[BIP-174] Clarify that partial_sig should be a valid.
 2022-01-16 01:56:59 +00:00
Sjors Provoost 6366f8ebcb bip174: document PSBT 0 handling of type > 0xFD 2022-01-12 16:39:21 +01:00
Sjors Provoost dc034af961 bip174: link to 'compact size' definition 2022-01-12 16:27:31 +01:00
Jeremy Rubin 469d62ce2b [BIP-174] Clarify that partial_sig should be a valid. 2022-01-08 15:12:33 -08:00
Dr Maxim Orlovsky d16522949d BIP-174: Remove PSBT_GLOBAL_SIGHASH_SINGLE_INPUT 2022-01-06 12:54:49 +01:00
Dr. Maxim Orlovsky 457e3545ba BIP-174: Removing PSBT_OUT_TAP_LEAF_SCRIPT 
`PSBT_OUT_TAP_LEAF_SCRIPT` seemed to appear in output key sections by copy-paste from input section. First, it shares the same byte no as `PSBT_OUT_TAP_TREE`, second its description talks about "witness"
 2021-11-23 18:43:34 +01:00
Kalle Rosenbaum a5fd6c8f60 BIP 0174: Clarify use of PSBT_IN_FINAL_* when data is empty 2021-10-27 20:43:34 +02:00
kallewoof e032df5720 Merge pull request #1198 from kallerosenbaum/patch-2 
BIP 0174: Fix typo in PSBT_OUT_BIP32_DERIVATION
 2021-09-30 08:10:19 +09:00
Kalle Rosenbaum 8918753df9 Fix typo in PSBT_OUT_BIP32_DERIVATION 2021-09-29 11:40:11 +02:00
Kalle Rosenbaum 33efbb2125 Correct format of PSBT_GLOBAL_TX_MODIFIABLE 
The descriptions for this field differ between bip370 and bip174. I suppose the correct format of PSBT_GLOBAL_TX_MODIFIABLE is the one in BIP370.
 2021-09-29 11:37:48 +02:00
azuchi 5943de4fa4 [BIP174] Fix broken link to psbt2 2021-08-15 15:49:43 +09:00
Andrew Chow c583f4dcbe Specify BIP 371 Taproot Fields for PSBT 
Add bip-0371.mediawiki, update readme, and update BIP 174 with
new field types.
 2021-07-20 15:03:38 -04:00
Andrew Chow 70e37e025d psbt2: Fix field number counting 
PSBT_OUT_SCRIPT should be 0x04, not 0x03.
 2021-06-21 17:09:14 -04:00
t-bast 4a1077d40e BIP 174: clarify key uniqueness 
The description of keytype incorrectly said it had to be unique: it's the
whole key that must be unique, not the keytype (since we can for instance
have multiple xpubs in the global map).
 2021-05-11 16:17:40 +02:00
Luke Dashjr 375f11a30c Merge pull request #1099 from achow101/more-psbt-tests 
BIP 174: Add test vectors for additional unsigned tx serialization
 2021-04-22 22:51:05 +00:00
Andrew Chow 754b77a915 BIP 174: Add test vectors for additional unsigned tx serialization 
There are some edge cases with unsigned tx serialization, so this adds
test vectors for them. Specifically, an unsigned tx with witness
serialization is invalid, a transaction with 0 inputs and 0 outputs is
valid, and a transaction with 0 inputs and non-0 outputs is valid.
 2021-04-08 13:34:18 -04:00
kiminuo f45d7c5784 Update bip-0174.mediawiki 
I, personally, find this easier to read.
 2021-03-31 10:22:39 +02:00
Luke Dashjr cd3885c0fb Merge pull request #1078 from dr-orlovsky/patch-5 
Fixing Simple Signer Algorithm
 2021-03-15 20:17:23 +00:00
Luke Dashjr d7cc27613e Merge BIP 370 2021-03-15 20:16:33 +00:00
Andrew Chow eaaf376099 174: Change PSBT unknown fields test to use higher numbers 
Previously these tests were using 0x0f as the unknown field number. As
these have now been defined, change them to use 0xf0 instead as it is
unlikely we will use those anything soon.
 2021-03-04 16:14:45 -05:00
Dr. Maxim Orlovsky 6db1e16486 Fixing Simple Signer Algorithm 
Simple Signer Algorithm was lacking an index argument (last one) on all function calls
 2021-03-02 20:26:59 +01:00
Andrew Chow b3d224f384 Specify BIP 370 PSBTv2 2021-02-12 16:09:35 -05:00
Luke Dashjr 518fd3fe07 Merge remote-tracking branch 'origin-pull/1036/head' 2021-02-04 00:56:42 +00:00
Luke Dashjr cf13cfa250 Merge pull request #988 from dr-orlovsky/patch-1 
BIP 174: require creator to initialize empty output fields
 2021-02-03 22:47:20 +00:00
Luke Dashjr f70132e58b BIP 174: Revert title change to fit length limit 
This partially reverts c0991047e2.
 2021-02-03 22:33:18 +00:00
Andrew Chow 88fb205264 Combine Appendix with field listing tables 2021-01-25 17:13:57 -05:00
Andrew Chow c27d5e8b96 Mark BIP 174 as final 2021-01-25 17:13:57 -05:00
Andrew Chow 80df41818e Include PSBT versions that can or must include field 2021-01-15 13:01:24 -05:00
Andrew Chow a4fb1b9de0 Specify procedure for new fields and versions 2021-01-15 13:01:24 -05:00
Andrew Chow c0991047e2 Explicitly specify PSBTv0 2021-01-15 13:01:19 -05:00
Andrew Chow 50fdf5435e Reformat BIP 174 2021-01-14 12:50:27 -05:00
Rusty Russell 6057fede05 BIP 174: clarify format of proprietary extensions. 
"Variable length string identifier" is not defined anywhere, and the suggestion
to use "0x00" is also deeply unclear.  I assumed it meant a nul-terminated
string!

Be explicit: you mean it must be a compact siz1\e unsigned int length, followed
by that many identifier bytes, followed by a compact size unsigned int subtype,
followed by optional keydata.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
 2021-01-13 16:55:42 -05:00
Ferdinando M. Ametrano 456c8c5088 fixed input test case description as per output test case description 2020-11-16 21:58:41 +01:00
fametrano c12af49c17 fixed typos 2020-11-15 09:53:06 +01:00
Luke Dashjr 1b7bf8e6aa Merge pull request #981 from apoelstra/2020-08-rename-hash-preimages 
BIP174: add `_IN_` to names of new hash preimage fields
 2020-10-05 16:31:18 +00:00
Luke Dashjr 602f4971ee Merge pull request #990 from dr-orlovsky/patch-3 
BIp 174: fixing typo in rationale reference with closed tag
 2020-10-05 16:19:38 +00:00
Dr. Maxim Orlovsky 6b3b636490 BIp 174: fixing typo in rationale reference with closed tag 2020-09-08 15:00:07 +02:00
Dr. Maxim Orlovsky d509aa2110 BIP 174: removing extra "fields" word 2020-09-07 18:38:23 +02:00
Dr. Maxim Orlovsky a159cca11f BIP 174: rename responsibilities->roles to match Bitcoin Core 
[Bitcoin Core uses "roles" instead of "responsibilities"](https://github.com/bitcoin/bitcoin/blob/master/src/psbt.h#L559) and it makes semantical sense (plus less verbose).
 2020-09-07 13:17:44 +02:00
Dr. Maxim Orlovsky 3d297861eb Require creator to initialize empty output fields 
The current version of the spec requires creator role to initialize empty input fields, but says nothing about output field initialization. At the same time, the following role, updater, "should also add redeemScripts, witnessScripts, and BIP 32 derivation paths to the input and output data if it knows them.", which does not make any sense if the fields were uninitialized. The [current Bitcoin Core implementation does this](https://github.com/bitcoin/bitcoin/blob/a24806c25d7a81a9c436de58eb5778d93abab16b/src/psbt.cpp#L12), and [other PSBT implementations, like rust-bitcoin, follow this practice](https://github.com/rust-bitcoin/rust-bitcoin/blob/master/src/util/psbt/mod.rs#L59)
 2020-09-07 13:06:43 +02:00
Andrew Poelstra 983b9840b3 bip 174: add new hash preimage fields to Appendix A 2020-08-27 15:02:44 +00:00
Andrew Poelstra e30d465a6a bip174: add _IN_ to new hash preimage fields 2020-08-26 13:49:42 +00:00