Commit Graph
4432 Commits
Author SHA1 Message Date
Murch 669d3b3570 BIP349: Fix preamble for CI issues 2024-11-14 16:36:45 -05:00
moonsettler 329b0d3db5 BIP-349 2024-11-14 16:30:28 -05:00
moonsettler b35383b68f Fixes and clarifications to address PR comments 2024-11-14 16:30:27 -05:00
Brandon Black 75351f2587 Add bip-internalkey 2024-11-14 16:30:24 -05:00
Jon Atack 16a23b777b Merge pull request #1691 from akarve/bip85-details
BIP-85: formatting and changelog updates, and add word cases for application 39'
2024-11-13 18:24:11 -08:00
Anthony Towns 65b312fe4a Remove ajtowns from bip-345 coauthor. 2024-11-14 10:21:30 +10:00
Aneesh Karve b398219e9c BIP-85: Move new reference to be near HMAC code 2024-11-09 14:30:02 -07:00
Aneesh Karve 88f4fc0ece BIP-85: Reorder sections to be more standard, convert HMAC discussion to footnote 2024-11-09 14:24:50 -07:00
Mark "Murch" Erhardt c58a428fb6 Merge pull request #1677 from scgbckbone/bip39_final
BIP39: update status from Proposed to Final
2024-11-08 12:22:47 -05:00
Jon Atack bffde65da1 Merge pull request #1695 from achow101/373-clarify-plain-pub
BIP373: Clarify where keys in MuSig fields may appear in the Taproot output
2024-11-08 09:02:58 -08:00
Jon Atack 711802c064 Merge pull request #1696 from bigspider/bip390-nit
BIP390: Clarify that musig cannot be used in top-level pk() or pkh()
2024-11-08 08:57:31 -08:00
Ava Chow 0ff32bd4c2 373: Clarify where keys in MuSig fields may appear in the Taproot output
- The aggregate pubkey in `PSBT_{IN,OUT}_MUSIG2_PARTICIPANT_PUBKEYS` does not have to
  appear anywhere in the Taproot output.
- The plain pubkeys in `PSBT_IN_MUSIG2_PUB_NONCE` and
  `PSBT_IN_MUSIG2_PARTIAL_SIG` must be either the output pubkey, or
  appears in a script, and not the internal key.
2024-11-08 11:43:15 -05:00
scgbckbone 829afccd1a change BIP39 status to Final 2024-11-08 11:32:40 +01:00
Salvatore Ingala 2e8f6ba5e7 Clarify that musig cannot be used in top-level pk() or pkh() 2024-11-08 10:11:47 +00:00
Jon Atack a12ce760c6 Merge pull request #1694 from pad01g/bip-388-test-vectors-valid-policies
Fix wrong test vector in BIP-388. Sometimes /<0;1>/* is missing. Sometimes it is incorrectly written as <0,1>.
2024-11-07 11:26:30 -08:00
pad01g dcb140a865 fix wrong test vector. sometimes /<0;1>/* is missing. sometimes incorrectly written as <0,1>. 2024-11-05 09:20:47 +00:00
Andrew Toth 4f5d87adc8 Bip Draft: DLEQ 2024-11-02 23:23:57 -04:00
Jon Atack 40e91fdb94 Merge pull request #1692 from jonatack/2024-10-update-bip125-status
BIP125: update status of Opt-in Full RBF Signaling to Obsolete
2024-10-30 17:51:52 -07:00
Jon Atack 3d86d94fa4 BIP125: update status from Proposed to Obsolete 2024-10-29 11:41:33 -06:00
Aneesh Karve 9133ab2451 BIP-85: Add 15 and 21 word entries to application 39' table 2024-10-25 12:05:56 -07:00
Aneesh Karve e0cc4f0e3d BIP-85: Rename to 'changelog' and move above Reference implementation(s) 2024-10-25 12:03:06 -07:00
Jon Atack 17c04f9fa1 Merge pull request #1676 from scgbckbone/bip85_final
BIP85: update status to Final
2024-10-25 08:13:16 -07:00
Aneesh KarveandJon Atack 8eac367dae BIP-85: Add co-author, language code & dice app, TPRV guidance, warn on BIP-32 divergence, grammar & clarity (#1679)
* BIP-85: Add language code, add dice app, warn on BIP-32 divergence, grammar clarity

* BIP-85: Add definite article

Co-authored-by: Jon Atack <jon@atack.com>

* BIP-85: PR suggestions on grammar, clarity

* BIP-85: Add change log

* BIP-85: Proper <references />, semver reference implementations, date on changelog, clarify warning language

* BIP-85: PR suggestion on range formatting

Co-authored-by: Jon Atack <jon@atack.com>

* BIP-85: wordsmith BIP-32 warning

Co-authored-by: Jon Atack <jon@atack.com>

* BIP-85: PR feedback on format, language, order of text

* BIP-85: PR grammar improvements

* BIP-85: Add dice app code to changelog

* BIP-85: Grammar and clarity from PR review

Co-authored-by: Jon Atack <jon@atack.com>

* BIP-85: Improve changelog and bump semvers accordingly; add alphanum password example to dice

* BIP-85: Rectify changelog dates and contents

* BIP-85: Correct 1.3.0 semver in changelog

* BIP-85: Remove fancy warning syntax b/c GH doesn't render it, wordsmith BIP32 warning

* BIP-85: Add and correct semvers in Reference Implementation section

---------

Co-authored-by: Jon Atack <jon@atack.com>
2024-10-25 08:11:00 -07:00
Jon Atack 52894e1aa7 Merge pull request #1681 from jonatack/2024-10-BIP2-update-URLs-to-https
BIP2: replace legacy http links with https
2024-10-22 14:51:39 -07:00
Jon Atack 385ac876d3 Merge pull request #1688 from jlopp/bip99
Fix BIP-99 Formatting
2024-10-20 08:45:33 -07:00
Jameson Lopp b6ea55291f fix formatting 2024-10-20 09:00:08 -04:00
Jon Atack 5284427971 Merge pull request #1683 from akarve/bip85-base64-vec-alone
BIP-85: Correct bad test vector for Base64
2024-10-15 09:45:25 -07:00
Jon Atack 0495fad99a Merge pull request #1686 from psztorc/patch-1
BIP300: fix up markup in comment header
2024-10-15 07:58:43 -07:00
Paul Sztorc b7bd93fed7 heading typo
this section is (rightly) commented out, but it still (wrongly) shows up at the table of contents in the beginning, this should fix it
2024-10-15 01:09:16 -04:00
Jon Atack 71aafb2a7f Merge pull request #1685 from bskrksyp9/patch-1
BIP158: fix up code comment typo in gentestvectors.go
2024-10-14 13:01:01 -07:00
Bhaskar Kashyap c4264ae980 fix typo
Corrected wording in comments
2024-10-14 22:35:43 +05:30
Aneesh Karve 2e98c7115c BIP-85: Correct bad test vector for Base64 2024-10-13 17:02:11 -07:00
Jon Atack caf8f78f75 Merge pull request #1682 from jonatack/2024-10-update-BIP327-status 2024-10-12 13:15:11 -07:00
Jon Atack 2eb22b8ec6 BIP327: update status 2024-10-11 11:19:56 -06:00
Jon Atack ca280b9762 BIP2: replace legacy http links with https 2024-10-08 11:03:37 -06:00
Jon Atack 541b6c4db4 BIP39: add license and copyright section
These are required per BIP-2, and they avoid user confusion as seen in

https://github.com/bitcoin/bips/pull/1395#issuecomment-2393915807
2024-10-08 10:54:43 -06:00
Jon Atack 83a1afd985 Merge pull request #1678 from JeremyRubin/patch-9
BIP119: remove James O'Beirne as co-author
2024-10-07 20:46:24 -06:00
Jeremy Rubin 80f8011e9c Remove j amesob from README.mediawiki from bip-0119 2024-10-06 14:55:31 -04:00
scgbckbone b0125501f8 change BIP85 status to Final 2024-10-05 16:07:40 +02:00
Jeremy Rubin a34cb4f769 Remove j amesob from bip-0119.mediawiki coauthor. 2024-10-05 10:01:53 -04:00
Jon Atack 9f588247d8 Merge pull request #1674 from bitcoin/revert-1600-master
Revert "BIP85: Clarify spec, correct test vectors, add Portuguese language code, add dice application"
2024-10-04 16:43:54 -07:00
Jon Atack 3f4a0a17bc Revert "BIP85: Update/clarify spec, add change log, Portuguese language code,…"
This reverts commit a1be309f91.
2024-10-04 16:18:52 -07:00
Jon Atack 758dfc9f55 Merge pull request #1672 from TheBlueMatt/2024-10-payment-expiry
Explicitly mention care around payment instruction expiry in 353
2024-10-02 11:09:20 -07:00
Matt Corallo e1aab46c63 Explicitly mention care around payment instruction expiry in 353
If someone puts a lightning BOLT 12 offer in a BIP 353 entry with
the offer expiring before the DNS entry's TTL (plus now), they may
get stuck being unpayable, so its worth explicitly mentioning that
people should take care here.
2024-10-02 16:46:57 +00:00
Aneesh Karve a1be309f91 BIP85: Update/clarify spec, add change log, Portuguese language code, dice application (#1600)
* BIP-85:

    * Add new maintainer (author unreachable)
    * Swap chain code and private key bytes in application 32' for consistentcy with BIP-32 (major change)
    * Correct derived entropy for application 128169' test vector (major change)
    * Clarify big endian serialization
    * Add the Portuguese language (9') to application 39'
    * Add dice application 89101'
    * Clarify Testnet support for XPRV application 32'
    * Minor grammar, format, clarity improvements
2024-09-25 08:00:54 -07:00
Paul Sztorc 34db0e99fa Link to latest code -- also shorter/better explanations (#1666)
* Update to CUSF activation client +shorter +clearer

* remove superfluous images

* link to CUSF client, shorter and clearer BIP text
2024-09-23 16:02:34 -07:00
Jon Atack 22660ad307 Merge pull request #1665 from EthanHeilman/patch-1
Uses consistent source for "CAT and Schnorr Tricks"
2024-09-08 17:43:15 -07:00
Ethan Heilman 3350d941a8 Uses consistent source for "CAT and Schnorr Tricks"
For "CAT and Schnorr Tricks I" we used https://medium.com/blockstream/cat-and-schnorr-tricks-i-faf1b59bd298

but for "CAT and Schnorr Tricks II"
https://www.wpsoftware.net/andrew/blog/cat-and-schnorr-tricks-ii.html

This commit changes this so that the original source wpsoftware is used for both links.
2024-09-08 14:34:30 -04:00
Mark "Murch" Erhardt 69d8eeb169 Merge pull request #1657 from TheBlueMatt/2024-07-psbt-dns
Add a PSBT per-output field for BIP 353 DNSSEC Proofs
2024-08-29 16:15:19 -04:00
Matt Corallo b0d5a07943 Add a PSBT per-output field for BIP 353 DNSSEC Proofs
When using BIP 353 for on-chain addresses (incl silent payments),
it is useful to be able to include DNSSEC proof information in
outputs of a PSBT, which we enable here by defining a standard
field for it.
2024-08-29 19:30:59 +00:00