frost/secp256k1-zkp
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bppp: check for overflow in generator allocation

Browse Source
This commit is contained in:
DarkWindman
2026-08-10 14:35:05 +03:00
parent a2b001cc20
commit 1de3864ff9
2 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/modules/bppp/main_impl.h
View File

@@ -28,6 +28,11 @@ secp256k1_bppp_generators *secp256k1_bppp_generators_create(const secp256k1_cont
if (ret == NULL) { if (ret == NULL) {
return NULL; return NULL;
} }
/* Ensure that multiplication will not wrap around */
if (n > SIZE_MAX / sizeof(*ret->gens)) {
free(ret);
return NULL;
}
ret->gens = checked_malloc(&ctx->error_callback, n * sizeof(*ret->gens)); ret->gens = checked_malloc(&ctx->error_callback, n * sizeof(*ret->gens));
if (ret->gens == NULL) { if (ret->gens == NULL) {
free(ret); free(ret);

2
src/modules/bppp/tests_impl.h
View File

@@ -28,6 +28,8 @@ static void test_bppp_generators_api(void) {
CHECK(gens != NULL); CHECK(gens != NULL);
gens_orig = gens; /* Preserve for round-trip test */ gens_orig = gens; /* Preserve for round-trip test */
CHECK(secp256k1_bppp_generators_create(CTX, SIZE_MAX / sizeof(secp256k1_ge) + 1) == NULL);
/* Serialize */ /* Serialize */
CHECK_ILLEGAL(CTX, secp256k1_bppp_generators_serialize(CTX, NULL, gens_ser, &len)); CHECK_ILLEGAL(CTX, secp256k1_bppp_generators_serialize(CTX, NULL, gens_ser, &len));
CHECK_ILLEGAL(CTX, secp256k1_bppp_generators_serialize(CTX, gens, NULL, &len)); CHECK_ILLEGAL(CTX, secp256k1_bppp_generators_serialize(CTX, gens, NULL, &len));