Merge pull request #134

29ae131 Make scalar_add_bit test's overflow detection exact (Pieter Wuille)
2014-12-04 12:19:56 +01:00
parent d5e8362ae5 29ae1310ce
commit 4d879a3a66
4 changed files with 13 additions and 8 deletions
--- a/src/tests.c
+++ b/src/tests.c
@@ -346,8 +346,7 @@ void scalar_test(void) {
            secp256k1_scalar_add(&b, &b, &b);
        }
        secp256k1_scalar_t r1 = s1, r2 = s1;
-        secp256k1_scalar_add(&r1, &r1, &b);
-        if (!(secp256k1_scalar_get_bits(&s1, 255, 1) == 1 && secp256k1_scalar_get_bits(&r1, 255, 1) == 0)) {
+        if (!secp256k1_scalar_add(&r1, &r1, &b)) {
            /* No overflow happened. */
            secp256k1_scalar_add_bit(&r2, bit);
            CHECK(secp256k1_scalar_eq(&r1, &r2));