Commit Graph
3 Commits
Author SHA1 Message Date
Wladimir J. van der Laan 4504be9cf1 Merge #1044: BIP155: Remove external link
cd1f225a0b BIP 155: Remove bitcoin.org link. (kiminuo)

Pull request description:

  Fix link.

ACKs for top commit:
  laanwj:
    Thanks you, ACK cd1f225a0b

Tree-SHA512: f798246ddffc2564385a2e071da02e47457ced15e502a8b500a10c2a4f5134cea750042e916bbfac39966e85efd554ad333a908be602a4cfcf09fa058840a527
2021-02-10 09:06:21 +01:00
Wladimir J. van der Laan 7e13d23d43 Merge #1043: BIP155: change when sendaddrv2 is to be sent
e549ed36e8 BIP155: change when sendaddrv2 is to be sent (Vasil Dimov)

Pull request description:

  Mandate to send `sendaddrv2` to the peer before sending our `verack`
  to them.

  This way we know that the peer does not support `addrv2` if we did not
  receive `sendaddrv2` from them before receiving their `verack`.

ACKs for top commit:
  MarcoFalke:
    ACK e549ed36e8
  harding:
    ACK e549ed36e8
  jnewbery:
    ACK e549ed36e8
  laanwj:
    re-ACK e549ed36e8
  jonatack:
    ACK e549ed3
  hebasto:
    ACK e549ed36e8, I believe that the establishing of connection invariants in a such manner--in response to the `version` and prior to sending the `verack`--is the right way both for new `addrv2` message and for other future features.

Tree-SHA512: ec8c40a7f857cc8b7df10812cb34d526299b6908b06049dfea24e25d830fc2d01bf4c052e9e4cd575ce4a1b93032cbe27323a390fe7fb90803a5975dd363d150
2020-12-09 12:27:50 +01:00
Wladimir J. van der Laan ebeb28ee0e Merge #1002: BIP155: Mention SHA3-256 explicitly
6ef71b344c BIP155: Small text improvements (Hennadii Stepanov)
562f1d7188 BIP155: Mention SHA3-256 explicitly (Hennadii Stepanov)

Pull request description:

  It seems better to clarify that `CHECKSUM` in Tor onion v3 address uses SHA3-256 hash function.

ACKs for top commit:
  vasild:
    ACK 6ef71b344
  laanwj:
    ACK 6ef71b344c

Tree-SHA512: b88c7dfeeda2a99cfe1042c9f4e7cbeb6047882bf97ce9c1dd5e1f4a30203a9a03702638cc4b6c3b573f6c0a05b73a5ca43a77352a5ca24a32d19be129f8b317
2020-10-06 15:51:27 +02:00